Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

lots of "Cannot forward frame yet" log entries #452

Closed
rade opened this issue Mar 11, 2015 · 0 comments · Fixed by #453
Closed

lots of "Cannot forward frame yet" log entries #452

rade opened this issue Mar 11, 2015 · 0 comments · Fixed by #453
Assignees
@rade
Labels
bug
Milestone
0.10.0

Comments

@rade
Copy link
Member

rade commented Mar 11, 2015

@bboreham has seen lots of "Cannot forward frame yet" log entries during testing. We do expect to see some, but this was quite a deluge.

Further examination shows that the log entry occurred as part of the routing of broadcast packets.

It turns out that our route calculation fails to exclude non-established connections from broadcast routing, even though it does do so for unicast routing.
@rade rade added the bug label Mar 11, 2015
rade added a commit to rade/weave that referenced this issue Mar 11, 2015
@rade
exclude non-established connections from broadcast routing
1ceb041 
We already excluded such connections from unicast routing.

Fixes weaveworks#452.
@rade rade mentioned this issue Mar 11, 2015
Merged
@rade rade self-assigned this Mar 11, 2015
bboreham added a commit that referenced this issue Mar 12, 2015
@bboreham
Merge pull request #453 from rade/452_only_broadcast_on_established
cce6175 
LGTM.  Fixes #452 - those messages go away entirely in my tests.
@rade rade modified the milestone: 0.10.0 Apr 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rade rade

Labels
bug
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

exclude non-established connections from broadcast routing rade/weave
2 participants
@rade @bboreham