Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

race condition between weave launch and the next command #500

Closed
bboreham opened this issue Mar 30, 2015 · 2 comments · Fixed by #509
Closed

race condition between weave launch and the next command #500

bboreham opened this issue Mar 30, 2015 · 2 comments · Fixed by #509
Labels
Milestone

Comments

@bboreham
Copy link
Contributor

The weave container process starts up asynchronously, so when weave launch returns, weave may not actually be ready to accept the next command.

This has been observed when the next command uses http, e.g. a weave status or weave connect. The symptom in this case is a silent exit with exitcode 7, which comes from the curl command when it cannot contact weave's http port.

One option would be to call weave status at the end of weave launch, looping a few times until we get an answer. This would also give better error reporting in the case that weave launch has failed, e.g. due to an error in the command-line syntax.

@rade rade added the chore label Mar 30, 2015
@bboreham
Copy link
Contributor Author

I have implemented my suggestion in b256555 (on another branch)

@bboreham
Copy link
Contributor Author

bboreham commented Apr 1, 2015

Sadly that had a bug, fixed in bboreham@f19cf7db5

@rade rade closed this as completed in #509 Apr 1, 2015
rade added a commit that referenced this issue Apr 1, 2015
Wait for the 'status' http call to return something after 'weave launch'

Fixes #500.
@rade rade modified the milestone: 0.10.0 Apr 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants