Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

weave shouldn't fail with "Generic error" when compiled against an old libpcap #623

Closed
rade opened this issue Apr 30, 2015 · 0 comments · Fixed by #625
Closed

weave shouldn't fail with "Generic error" when compiled against an old libpcap #623

rade opened this issue Apr 30, 2015 · 0 comments · Fixed by #625
Assignees
@dpw
Labels
chore
Milestone
0.11.0

Comments

@rade
Copy link
Member

rade commented Apr 30, 2015

Weave needs pcap >= 1.5.0. The errors we get from gopacket when running with an older version are less than helpful. So we should check that we have the right version. Ideally at build time, but that may be more trouble than it's worth.
@rade rade added the chore label Apr 30, 2015
@rade rade changed the title check pcap version at build time check pcap version Apr 30, 2015
@dpw dpw self-assigned this May 1, 2015
@dpw dpw mentioned this issue May 1, 2015
Merged
@dpw dpw changed the title check pcap version weave shouldn't fail with "Generic error" when compiled against an old libpcap May 1, 2015
@rade rade closed this as completed in #625 May 2, 2015
rade added a commit that referenced this issue May 2, 2015
@rade
Merge branch 'dpw-check-libpcap-version'
5aa912c 
Fixes #623.
@rade rade modified the milestone: 0.11.0 May 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dpw dpw

Labels
chore
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Improve the "Generic error" message when compiled against old libpcap dpw/weave
2 participants
@dpw @rade