Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

[proxy] exec instead of run application process #708

Closed
rade opened this issue May 19, 2015 · 2 comments · Fixed by #713
Closed

[proxy] exec instead of run application process #708

rade opened this issue May 19, 2015 · 2 comments · Fixed by #713
Labels
chore [component/proxy]
Milestone
0.11.0

Comments

@rade
Copy link
Member

rade commented May 19, 2015

It seems odd to me that weavewait uses Cmd.Run() instead of syscall.Exec(). Surely it would be better to "become" the application process, instead of spawning it as a separate process and waiting for its completion.
@rade rade added the chore label May 19, 2015
@rade rade added this to the 0.11.0 milestone May 19, 2015
paulbellamy added a commit to paulbellamy/weave that referenced this issue May 20, 2015
@paulbellamy
[proxy] use exec instead of run, to replace weavewait with subprocess
814b763 
Closes weaveworks#708
paulbellamy added a commit to paulbellamy/weave that referenced this issue May 20, 2015
@paulbellamy
[proxy] use exec instead of run, to replace weavewait with subprocess
818e162 
Closes weaveworks#708
@paulbellamy paulbellamy mentioned this issue May 20, 2015
Merged
@paulbellamy
Copy link
Contributor

Was also meaning to ask about the intended weavewait behaviour when the network fails to attach. At the moment it logs an error, and runs the subcommand anyway. Should it do that, or exit early?

@rade
Copy link
Member Author

rade commented May 20, 2015

Should it do that, or exit early?

Either is reasonable. So let's leave it as is for now.

@rade rade closed this as completed in #713 May 20, 2015
rade added a commit that referenced this issue May 20, 2015
@rade
Merge pull request #713 from paulbellamy/proxy-exec
0220f9a 
use exec instead of run, to replace weavewait with subprocess

Closes #708.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
chore [component/proxy]
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

[proxy] use exec instead of run, to replace weavewait with subprocess paulbellamy/weave
3 participants
@rade @paulbellamy @awh