Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

make weave launch launch everything #962

Closed
rade opened this issue Jun 18, 2015 · 5 comments
Closed

make weave launch launch everything #962

rade opened this issue Jun 18, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@rade
Copy link
Member

rade commented Jun 18, 2015

Running the weave router, dns and proxy is now the common case, rather than the exception. So we should make that more convient...

  1. weave launch should launch all three
  2. weave stop should stop all three
  3. weave launch-router should launch just the router (i.e. it's the current weave launch)
  4. weave stop-router should stop just the router (i.e. it's the current weave stop)

Rather than getting all clever about arg parsing, weave launch should simply pass all args to (just) the router. In the unusual cases where a user wants to pass arguments to the dns or proxy, they can launch all three separately instead.

weave launch should fail with a suitable "already running" error (as now) if any of the three are already running, and not start any of the others. And if starting any of them fails, it should exit with a failure.

weave stop should stop any containers running, report a "not running" error (as now), and succeed.

@rimusz
Copy link

rimusz commented Jun 18, 2015

+1

@rade rade mentioned this issue Jun 23, 2015
4 tasks
@awh awh self-assigned this Jun 24, 2015
@awh
Copy link
Contributor

awh commented Jun 24, 2015

weave launch should launch all three

Should it still print out the container IDs, now that there will be three of them?

@rade
Copy link
Member Author

rade commented Jun 24, 2015

Should it still print out the container IDs, now that there will be three of them?

They have never been all that useful, I guess, so no.

@awh
Copy link
Contributor

awh commented Jun 24, 2015

And if starting any of them fails, any others already started should be stopped.

Does this imply that for weave stop, if stopping any of them fails that any others already stopped should be started?

@rade
Copy link
Member Author

rade commented Jun 24, 2015

Does this imply that for weave stop, if stopping any of them fails that any others already stopped should be started?

No.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants