Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

shorten launch time by reducing sleep #992

Closed
rade opened this issue Jun 23, 2015 · 1 comment
Closed

shorten launch time by reducing sleep #992

rade opened this issue Jun 23, 2015 · 1 comment
Assignees
Milestone

Comments

@rade
Copy link
Member

rade commented Jun 23, 2015

I have discovered that sleeping for 1 second in wait_for_status retries is slowing down weave launch a fair bit. Ideally we'd sleep for a fractional time, but that is non-POSIX so we need to find a way around that.

@dpw
Copy link
Contributor

dpw commented Jun 23, 2015

I think just trying a fractional time and seeing whether sleep dies with an error will be fine. But an alternative would be to do sleep --version and look for an appropriate coreutils version (I doubt POSIX specifies what --version should do, but it is even less likely to cause a problem.)

rade added a commit to rade/weave that referenced this issue Jun 23, 2015
This reduces `weave launch|launch-dns` execution time.

Closes weaveworks#992.
@awh awh assigned rade Jun 24, 2015
rade added a commit to rade/weave that referenced this issue Jun 24, 2015
This reduces `weave launch|launch-dns` execution time.

Closes weaveworks#992.
@dpw dpw closed this as completed in #993 Jun 24, 2015
dpw added a commit that referenced this issue Jun 24, 2015
Sleep for 0.1s instead of 1s in the wait_for_status loop.

Closes #992.
@rade rade modified the milestone: 1.1.0 Jul 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants