Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Extend 'go get' to tests #1015

Merged
merged 1 commit into from
Jun 25, 2015
Merged

Extend 'go get' to tests #1015

merged 1 commit into from
Jun 25, 2015

Conversation

bboreham
Copy link
Contributor

The -t flag asks Go to fetch anything required for tests, which is more necessary now we have added testify.

I considered adding a go get line to the make tests target, but it's already unwieldy and not necessary if people do 'make' first.

The `-t` flag asks Go to fetch anything required for tests, which is more necessary now we have added testify.
rade added a commit that referenced this pull request Jun 25, 2015
@rade rade merged commit ea59c6c into master Jun 25, 2015
@rade rade deleted the go-get-tests branch June 25, 2015 16:01
@rade
Copy link
Member

rade commented Jun 25, 2015

This doesn't actually work. sigh

make clean; make; make tests
...
common/sched_queue_test.go:8:2: cannot find package "github.com/stretchr/testify/require" in any of:
...

@tomwilkie
Copy link
Contributor

bin/test in scope handles this nicely...

On Thursday, 25 June 2015, Matthias Radestock notifications@github.com
wrote:

This doesn't actually work. sigh

make clean; make; make tests
...
common/sched_queue_test.go:8:2: cannot find package "github.com/stretchr/testify/require" in any of:
...


Reply to this email directly or view it on GitHub
#1015 (comment).

@rade rade added this to the 1.1.0 milestone Jul 2, 2015
@rade
Copy link
Member

rade commented Aug 31, 2015

Fixed in 82da45a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants