Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Change default IP allocation range from 10.128/10 to 10.32/12 #1070

Merged
merged 1 commit into from
Jul 7, 2015

Conversation

bboreham
Copy link
Contributor

@bboreham bboreham commented Jul 3, 2015

To avoid clashing with Digital Ocean's and GCE's default private networks.
Fixes #1036

(note this PR is raised against master; will re-raise if it was supposed to be against 1.0)

@rade
Copy link
Member

rade commented Jul 4, 2015

Looks like our new choice clashes with CircleCI. Don't know whether that is due to CircleCI itself or our specific CircleCI setup. @tomwilkie any clues?

@tomwilkie
Copy link
Contributor

Id be surprised if it's a circle thing - must clash with gce.

I'll investigate tomorrow, but we should make this default smarter - for
instance, include it in the paxos first stage or something.

On Saturday, 4 July 2015, Matthias Radestock notifications@github.com
wrote:

Looks like our new choice clashes with CircleCI. Don't know whether that
is due to CircleCI itself or our specific CircleCI setup. @tomwilkie
https://github.com/tomwilkie any clues?


Reply to this email directly or view it on GitHub
#1070 (comment).

@tomwilkie
Copy link
Contributor

Yeah on my GCE VM I have an IP address 10.240.96.113, which is in 10.192/10 I think

eth0      Link encap:Ethernet  HWaddr 42:01:0a:f0:60:71  
          inet addr:10.240.96.113  Bcast:10.240.96.113  Mask:255.255.255.255
          UP BROADCAST RUNNING MULTICAST  MTU:1460  Metric:1
          RX packets:7887697 errors:0 dropped:0 overruns:0 frame:0
          TX packets:8218029 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000 
          RX bytes:9258627273 (9.2 GB)  TX bytes:7594574193 (7.5 GB)

@bboreham bboreham changed the title Change default IP allocation range from 10.128/10 to 10.192/10 Change default IP allocation range from 10.128/10 to 10.32/12 Jul 6, 2015
@bboreham bboreham removed their assignment Jul 6, 2015
@bboreham
Copy link
Contributor Author

bboreham commented Jul 6, 2015

what needs doing on this? I changed the range again.

@rade
Copy link
Member

rade commented Jul 6, 2015

ah, didn't see. No /11?

@bboreham
Copy link
Contributor Author

bboreham commented Jul 6, 2015

The even number seemed aesthetically much better, to my eyes. And halves the chance of something conflicting...

@rade rade assigned rade and unassigned bboreham Jul 7, 2015
rade added a commit that referenced this pull request Jul 7, 2015
Change default IP allocation range from 10.128/10 to 10.32/12

Closes #1036.
@rade rade merged commit 41b0c2a into master Jul 7, 2015
@rade rade deleted the 1036-change-iprange branch July 7, 2015 01:24
@rade rade modified the milestones: current, 1.1.0 Jul 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants