This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Make DNS gossip converge correctly #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Abide by gossip interface (return nil, not empty gossip) so gossip converges! - Make sure we don't say an old entry version is new to us; add some more tests. - Add dns test for 3 (or N) hosts - Extend mock gossip router to ensure reconsumption off diffs yield nil - Don't increment version when re-adding existing entry.
rade
added a commit
that referenced
this pull request
Jul 15, 2015
Make DNS gossip converge correctly Fixes #1151
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1151