This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Remove misleading comment and lowercase deniedBy #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the comment "don't make the caller wait" applies to both branches of that if clause, and having it on one branch implies the other does make the caller wait * there's no reason for DeniedBy to start with a capital: it's a method on a private struct and it's not part of an interface.
rade
added a commit
that referenced
this pull request
Jul 28, 2015
Remove misleading comment and lowercase deniedBy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of that if clause, and having it on one branch implies the other
does make the caller wait
method on a private struct and it's not part of an interface.