This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Proxy chunking should handle arbitrarily large chunks #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How many images do you need to create to make it fail? Can we make lots of On Tuesday, 4 August 2015, Paul Bellamy notifications@github.com wrote:
|
|
Good call, actually can fail it using a few images with large labels. |
| return cr.err | ||
| } | ||
|
|
||
| func (cr *ChunkedReader) beginChunk() (n uint64) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tomwilkie
added a commit
that referenced
this pull request
Aug 10, 2015
Proxy chunking should handle arbitrarily large chunks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1257.
At the moment I'm unit testing it to accept a 1 megabyte chunk. Have tried it with a failing
docker images -a, but it requires having loads of images, so I'm loathe to add it into the integration test suite.