This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
extract test functions for "start container via proxy" #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also eliminates the redefinition of 'start_container' by some of the tests, which causes failures when multiple tests are run with `run_all.sh`. Fixes #1294.
|
NB: this requires a little bit extra work when merging from 1.0 into master, to switch some of the new tests there to use the new functions. So I'd rather merge this myself. |
|
LGTM |
rade
added a commit
that referenced
this pull request
Aug 13, 2015
…_start extract test functions for "start container via proxy" Fixes #1294.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also eliminates the redefinition of 'start_container' by some of the tests, which causes failures when multiple tests are run with
run_all.sh.Fixes #1294.