Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Refactor dns handlers #1344

Merged
merged 8 commits into from
Aug 21, 2015
Merged

Refactor dns handlers #1344

merged 8 commits into from
Aug 21, 2015

Commits on Aug 20, 2015

  1. refactor dns handlers 

    introduce a handler struct, which

- enables lifting of all the handle* closures to methods
- eliminates the passing around of defaultMaxResponseSize
- reduces the number of free-floating functions
    @rade
    rade committed Aug 20, 2015
    Configuration menu
    Copy the full SHA
    8182022 View commit details
    Browse the repository at this point in the history

  2. cosmetic

    @rade
    rade committed Aug 20, 2015
    Configuration menu
    Copy the full SHA
    69986e7 View commit details
    Browse the repository at this point in the history

  3. extract response construction

    @rade
    rade committed Aug 20, 2015
    Configuration menu
    Copy the full SHA
    7c7c302 View commit details
    Browse the repository at this point in the history

  4. inline truncateResponse

    @rade
    rade committed Aug 20, 2015
    Configuration menu
    Copy the full SHA
    322441d View commit details
    Browse the repository at this point in the history

  5. simplify response truncation

    @rade
    rade committed Aug 20, 2015
    Configuration menu
    Copy the full SHA
    2ea27ec View commit details
    Browse the repository at this point in the history

  6. optimise response construction when no truncation is required 

    no need to do a binary search if all the answers fit
    @rade
    rade committed Aug 20, 2015
    Configuration menu
    Copy the full SHA
    9a7abe6 View commit details
    Browse the repository at this point in the history

  7. extract response writing

    @rade
    rade committed Aug 20, 2015
    Configuration menu
    Copy the full SHA
    0b5f5fd View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2015

  1. move error response construction to handler 

    and implement it in terms of existing functions, plus provide a
convenience method for sending the rather common NameError.
    @rade
    rade committed Aug 21, 2015
    Configuration menu
    Copy the full SHA
    2284bc2 View commit details
    Browse the repository at this point in the history