This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Get proxy to re-attach weave router if it restarts #1359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
401-reattach-weave
branch
from
099cfcb to
1bab979
Compare
bboreham
force-pushed
the
401-proxy-start-events
branch
2 times, most recently
from
9fbb578 to
1e23443
Compare
bboreham
force-pushed
the
401-reattach-weave
branch
from
1bab979 to
3f79789
Compare
|
|
||
| # Recreate the parameter values that are set when the router is first launched | ||
| fetch_router_args() { | ||
| IPRANGE=$(docker inspect -f '{{.Args}}' $1 | grep -o -e '-ipalloc-range [^ ]*') |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Replaced by #1518 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on to #1210, created as a separate PR for clarity.
Fixes part (a) in #401
You get a bit of noise in the logs on a total restart (e.g. a reboot), because the router isn't necessarily up and listening before we start re-attaching other containers. But it all works out in the end, because the router attach re-does all the parts that went wrong.