Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Looser docker-py test matcher for parallelization #1370

Merged
merged 1 commit into from
Sep 1, 2015

Conversation

paulbellamy
Copy link
Contributor

Previous one was only catching TestFoo, not FooTest. Python uses both.

Will expose a broken the test.

Found in #1367

Depends on #1367

@bboreham
Copy link
Contributor

According to the docs, FooTest shouldn't match.

The test that @rade noted was test_valid_no_config_specified, for which we would just want to change Test to [Tt]est in the regex.

@paulbellamy
Copy link
Contributor Author

Right, ok. Probably worth fixing in docker-py then. The regex is matching class names, not the method names.

@bboreham
Copy link
Contributor

On closer inspection, the test is using pytest unittest integration, so maybe matching class .*TestCase is closer to what we want.

bboreham added a commit that referenced this pull request Sep 1, 2015
@bboreham bboreham merged commit 6a34995 into master Sep 1, 2015
@paulbellamy paulbellamy deleted the docker-py-test-matcher branch September 1, 2015 15:47
@rade rade added this to the 1.1.0 milestone Sep 3, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants