This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
correctly report snapshot versions #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way we no longer rely on the weavexec image version tag, which may not always be present. Since the proxy is embedded in the weaveexec image, this effectively versions the image. Also report the *local* script version instead of the embedded script version. There is no point in reporting the latter since it will always match the weaveexec version. Closes #1341.
paulbellamy
added a commit
that referenced
this pull request
Sep 14, 2015
correctly report snapshot versions
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report the proxy version instead of weaveexec version. That way we no longer rely on the weavexec image version tag, which may not always be present. Since the proxy is embedded in the weaveexec image, this effectively versions the image.
Also report the local script version instead of the embedded script version. There is no point in reporting the latter since it will always match the weaveexec version.
Closes #1341.