This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Override sneaky /start HostConfig params #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| proxy_start_container $HOST1 --name=c1 | ||
| proxy docker_on $HOST1 create --name=c2 $SMALL_IMAGE grep "^1$" /sys/class/net/ethwe/carrier | ||
| # Now start c2 with a sneaky HostConfig | ||
| curl -X POST -H Content-Type:application/json -d '{"NetworkMode": "container:c1"}' http://$HOST1:12375/v1.20/containers/c2/start |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
This should be branched off 1.1, not master. |
paulbellamy
force-pushed
the
1368-start-hostconfig
branch
3 times, most recently
from
19f6248
to
8873d01
Compare
| proxy docker_api_on $HOST1 POST /v1.20/containers/c3/start '{"Binds":[],"Dns":null,"DnsSearch":null,"ExtraHosts":null,"VolumesFrom":null,"Devices":null,"NetworkMode":""}' | ||
| assert "docker_on $HOST1 inspect -f '{{.State.Running}} {{.State.ExitCode}} {{.HostConfig.Dns}}' c3" "false 0 [$docker_bridge_ip]" | ||
|
|
||
| end_suite |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
paulbellamy
force-pushed
the
1368-start-hostconfig
branch
3 times, most recently
from
b80e465
to
27d9f3d
Compare
paulbellamy
force-pushed
the
1368-start-hostconfig
branch
from
27d9f3d
to
45526fc
Compare
paulbellamy
force-pushed
the
1368-start-hostconfig
branch
from
45526fc
to
547c9e7
Compare
rade
added a commit
that referenced
this pull request
Sep 22, 2015
Override sneaky /start HostConfig params Fixes #1368.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1368