Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

strip off @... from interface names returned by ip link show #1504

Merged
merged 1 commit into from
Oct 4, 2015
Merged

strip off @... from interface names returned by ip link show #1504

merged 1 commit into from
Oct 4, 2015

Conversation

rade
Copy link
Member

@rade rade commented Oct 4, 2015

Apparently kernel 4.2 adds these, which breaks weave reset when we pass the names to `ip link del'.

Fixes #1364.

@rade
strip off @... from interface names returned by ip link show
37ea8a2 
Apparently kernel 4.2 adds these, which breaks `weave reset` when we
pass the names to `ip link del'.

Fixes #1364.
@rade
Copy link
Member Author

rade commented Oct 4, 2015

@dpw mind taking a look at this? I have not been able to test this since I failed miserably in my attempt to create an Ubuntu 15.10 vagrant VM.

@rade rade added this to the 1.1.1 milestone Oct 4, 2015
@dpw
Copy link
Contributor

dpw commented Oct 4, 2015

Ok, tested with the 15.10 daily. With master, weave --local reset leaves vethweplNNNN netdevs for containers on the weave network around. With this branch, they get cleaned up.

@rade
Copy link
Member Author

rade commented Oct 4, 2015

You also got an "Cannot find device" error on master, right?

@dpw
Copy link
Contributor

dpw commented Oct 4, 2015

You also got an "Cannot find device" error on master, right?

Not visibly: That ip link del line you modified has an >/dev/null 2>&1 on it. If I try it by hand I see that error.

@rade
Copy link
Member Author

rade commented Oct 4, 2015

Hmm. That's odd, given the user report in #1356.

@rade
Copy link
Member Author

rade commented Oct 4, 2015

Ah, the >/dev/null 2>&1 got added in #1365 (1.0.3).

@dpw
Copy link
Contributor

dpw commented Oct 4, 2015

Hmm. That's odd, given the user report in #1356.

I'd guess they were running a version prior to 1df752

dpw added a commit that referenced this pull request Oct 4, 2015
@dpw
Merge 1364-ip-link-kernel-4.2 (PR #1504)
8fe0228 
strip off @... from interface names returned by `ip link show`
@dpw dpw merged commit 37ea8a2 into 1.1 Oct 4, 2015
@rade
Copy link
Member Author

rade commented Oct 4, 2015

Yes, #1365 was the PR that closed #1356.

@awh awh deleted the 1364-ip-link-kernel-4.2 branch November 9, 2015 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@rade @dpw