This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
dns-{add,remove} can add/remove non-container DNS records
#1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...by omitting the container name/id Fixes #1385.
...instead of the weave container. This is cleaner. 'weave:extern' because typically these entries will refer to external (non-weave) IP addresses. And because it's the same length as 'weave:expose', which is desirable for 'weave status dns' output.
rade
force-pushed
the
1385-non-container-dns-add
branch
from
ff924e8
to
e42c811
Compare
|
Once we are happy with this I will create an issue to address the caveat, namely that records get removed when stopping the peer on which they were added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by omitting the container name
We associate non-container dns entries with 'weave:extern' because typically these entries will refer to external (non-weave) IP addresses. 'weave:extern' also happens to be the same length as the existing 'weave:expose' pseudo-container, which is desirable for 'weave status dns' output layout.
Fixes #1385.