This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Print request and response json when debugging weaveproxy #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth noting not all commands use unmarshalRequestBody, so I don't think this covers everything. |
|
ok you got me - which ones don't use it? |
|
surely we want something in |
|
|
Ones we don't modify don't need to be printed. |
rade
added a commit
that referenced
this pull request
Oct 15, 2015
Print request and response json when debugging weaveproxy Fixes #1515
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1515
Simply added to debug-level logging, to avoid the added complexity of a new command-line flag to turn this on.
Thanks to @tomwilkie for the implementation