Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

'weave --local create-bridge' is not compatible with fastdp #1562

Merged
merged 1 commit into from
Oct 20, 2015

Conversation

dpw
Copy link
Contributor

@dpw dpw commented Oct 20, 2015

Addresses #1552.

@rade
Copy link
Member

rade commented Oct 20, 2015

Hmm. So weave create-bridge doesn't do something useful even when docker is running?

@rade rade assigned awh Oct 20, 2015
@dpw
Copy link
Contributor Author

dpw commented Oct 20, 2015

Whether weave create-bridge does something useful is questionable. It creates something, but it's not a normal bridge, and you can't do anything with it that doesn't involve further weave commands that would do create_bridge anyway. So I can't think of a reason why someone would do weave create-bridge rather than weave create-bridge --local. Can you?

@rade
Copy link
Member

rade commented Oct 20, 2015

I can't think of a reason why someone would do weave create-bridge rather than weave create-bridge --local. Can you?

I can't. Though perhaps the comment stating "create-bridge is run without the docker daemon" could do with some rephrasing, since create-bridge may be run with the docker daemon.

@awh
Copy link
Contributor

awh commented Oct 20, 2015

@dpw would you like to reword the comment before I merge?

@dpw
Copy link
Contributor Author

dpw commented Oct 20, 2015

Done

awh added a commit that referenced this pull request Oct 20, 2015
'weave --local create-bridge' is not compatible with fastdp
@awh awh merged commit 720862d into weaveworks:master Oct 20, 2015
@awh awh added this to the 1.2.0 milestone Oct 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants