This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Move test/tls program into Makefile so it builds inside the build container #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
make-test-tls
branch
from
65e8e05
to
c981cff
Compare
awh
added a commit
that referenced
this pull request
Dec 8, 2015
Move test/tls program into Makefile so it builds inside the build container
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building outside the container was breaking the CircleCI build, because CircleCI was variously running Go 1.4 and 1.5.1 which didn't match the build container.
This also saves ~3 seconds on every run of test/setup.sh