This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
better emulation of connections in gossip tests #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rade
force-pushed
the
1765-test-gossip-surrogate-failure
branch
from
1b6d156
to
9c3edac
Compare
real Connections do not process gossip until after AddConnection. mockChannelConnection wasn't behaving in that way, which resulted in some sporadic test failures since it would cause some gossip to get processed too early, which in turn would trigger gc of some of the just-received peers, which we would then find missing in the test assertions. To fix this we introduce a latch on mockChannelConnection which closes when the remote end is ready to receive gossip. Effectively this emulates the entering of LocalConnection.receiveTCP after the call to AddConnection completes. Unfortunately an open latch will cause sendPendingGossip to block. We get around that by abandoning checks in "half-connected" connection states. Fixes #1765.
rade
force-pushed
the
1765-test-gossip-surrogate-failure
branch
from
9c3edac
to
ab902b4
Compare
|
You've removed all testing of one-sided connections? I guess that's what the last paragraph of your description says. |
bboreham
added a commit
that referenced
this pull request
Dec 11, 2015
…ailure better emulation of connections in gossip tests. Fixes #1765.
This was referenced Dec 12, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Real
Connections do not process gossip until afterLocalPeer.AddConnection.mockChannelConnectionwasn't behaving in that way, which resulted in some sporadic test failures since it would cause some gossip to get processed too early, which in turn would trigger gc of some of the just-received peers, which we would then find missing in the test assertions.To fix this we introduce a latch on
mockChannelConnectionwhich closes when the remote end is ready to receive gossip. Effectively this emulates the entering ofLocalConnection.receiveTCPafter the call toAddConnectioncompletes.Unfortunately an open latch will cause
sendPendingGossipto block. We get around that by abandoning checks in "half-connected" connection states.Fixes #1765.