This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Make weave global-scope driver compatible with Docker swarm mode #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
changed the title
Documentation changes:modified plugin |
|
Unfortunately I was mistaken in thinking that Docker 1.13 supports "v1" plugins in swarm mode. There is a filtering routine which was re-enabled by moby/swarmkit#1808 which does not include the (still checking whether this is the intended position of Docker) |
bboreham
force-pushed
the
docker-swarm
branch
from
c9c37ef to
0095931
Compare
Documentation changes:modified plugin |
Implement (empty) endpoints for new NetworkAllocate and NetworkFree calls Also update libnetwork and docker dependencies
marccarre
force-pushed
the
docker-swarm
branch
from
0095931 to
8172e25
Compare
Documentation changes:modified plugin |
|
I'm closing this w/o merging, as #2727 includes all the commits of this PR. |
|
This doesn't work with Docker Swarm Standalone(https://github.com/docker/swarm) which many Docker vendors and third-party uses. Not everyone uses Swarm Mode. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2396 (also #2651)
The GetCapabilities change is unnecessary but without it we get some unnecessary warning messages from Docker which slightly confused the diagnosis of some issues.
Also updated the
toolssubmodule because testrunner stopped building. Updated to a commit beforeshfmtwas made mandatory.