This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Trim the JSON logged for Kubernetes objects by weave-npc #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove things like "args" and "env" which bulk the logs, aren't relevant to the function of weave-npc, and may include sensitive information. Use a black-list rather than a white-list because we can't be sure what information will be necessary in future.
brb
reviewed
Nov 22, 2017
| a, _ := json.Marshal(v) | ||
| // Convert this back into a tree of key-value maps | ||
| var m map[string]interface{} | ||
| if err := json.Unmarshal(a, &m); err != nil { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log size of weave-npc was getting out of hand. We currently run at debug level by default, which includes a full JSON dump of every Kubernetes objects received.
Remove things like "args" and "env" which bulk the logs, aren't relevant to the function of weave-npc, and may include sensitive information.
Use a black-list rather than a white-list because we can't be sure what information will be necessary in future.