This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Make proxy use configured WeaveDNS address #3196
Merged
+26
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was needed when we ran inside a container network namespace
rather than assuming it is listening on the weave bridge
instead of obtaining it via the http api
bboreham
force-pushed
the
issues/1770-proxy-dns-address
branch
from
11bcdc6 to
e7f3010
Compare
brb
approved these changes
Jan 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1770
Remaining work on #1770 is to modify the
weavescript to respect the--dns-listen-addressparameter and document it.