This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Fetch DNS listen address from daemon #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
issues/1770-fetch-dns-address
branch
from
2a05010
to
55114ba
Compare
bboreham
force-pushed
the
issues/1770-fetch-dns-address
branch
from
55114ba
to
93e01dc
Compare
bboreham
force-pushed
the
issues/1770-fetch-dns-address
branch
from
93e01dc
to
dd9593b
Compare
bboreham
force-pushed
the
issues/1770-fetch-dns-address
branch
from
52f42cd
to
c0e9b10
Compare
bboreham
force-pushed
the
issues/1770-fetch-dns-address
branch
from
c0e9b10
to
d8e9fc9
Compare
instead of assuming it's on the Docker bridge Also move DNS address validation into NewDNSServer(), so we only do it once.
It was used as part of 'weave run'; does not make sense to support --name, -h, etc., on 'weave dns-args'.
Now that `weave dns-args` doesn't parse any flags we need to call it or not call it, which `start_container` will do for us. Also add back the part of the test where we run weaver with and without DNS, which had become lost in 8b061fd Also change a couple of tests to use proxy to start containers, again to avoid needing `dns-args` to parse flags.
bboreham
force-pushed
the
issues/1770-fetch-dns-address
branch
from
2b26998
to
9ffd0e3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1770
Also drive-by cleanup of
dns_args()which was doing a lot of arg parsing needed forweave run, but not much use any more.(Note if you were using
weave dns-argswith arguments like-hthen that won't work now, but it was never documented to work)