This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Wait 5 seconds to let pod connect before rolling next pod #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebryant
approved these changes
Feb 8, 2018
|
I don't think it'll slow down an initial install, when we deploy weave for the first time, all pods are created immediately - it's only when it's doing a rolling update does it start caring that they're up for long enough before it destroys the next pod |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a rolling update we don't want Kubernetes to go as fast as it can across nodes, because each node will have a short interruption as iptables rules are recreated.
I think this will also have the effect of slowing down a first install, but hopefully people can wait a few extra seconds.
I picked 5 seconds somewhat arbitrarily; the setting may need more experimentation.
Note we don't specify a readiness check at the moment, so Kubernetes equates "running" with "ready". If the pod crashes immediately it will not be ready.