This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Remove subprocess for changing netns #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Go 1.10 has removed the issue which made us do this.
bboreham
force-pushed
the
withnetns-inproc
branch
from
19a638d to
c2c1441
Compare
brb
reviewed
May 1, 2018
| @@ -1,10 +1,8 @@ | |||
| package net | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
brb
reviewed
Jun 4, 2018
| // for more details and make sure that you understand the implications before | ||
| // using the function! | ||
| func WithNetNSUnsafe(ns netns.NsHandle, work func() error) error { | ||
| func WithNetNS(ns netns.NsHandle, work func() error) error { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
net/netdev.go
Outdated
|
|
||
| for _, link := range links { | ||
| if _, found := indexes[link.Attrs().Index]; found { | ||
| netdev, err := LinkToNetDev(link) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
net/veth.go
Outdated
| for _, link := range links { | ||
| ifName := link.Attrs().Name | ||
| if strings.HasPrefix(ifName, prefix) { | ||
| ConfigureARPCache(rootPath+"/proc", ifName) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
net/veth.go
Outdated
| // NB: This function can be used only by a process that terminates immediately | ||
| // after calling the function as it changes netns via WithNetNSLinkUnsafe. | ||
| // ConfigureARP is a helper for the Docker plugin which doesn't set the addresses itself | ||
| func ConfigureArp(prefix, rootPath string) error { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
brb
approved these changes
Jun 5, 2018
This was referenced Jan 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Go 1.10 has removed the issue which made us do this.
Less faffing around, more efficient.