This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
3206: Protect against CNI plugin being called with the host namespace #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed on two counts: one lint:
"missing secret" is because non-weaveworks repos don't have the credentials to create VMs to run the smoke tests. |
bboreham
reviewed
Jul 13, 2018
plugin/net/cni.go
Outdated
| @@ -117,6 +117,16 @@ func (c *CNIPlugin) CmdAdd(args *skel.CmdArgs) error { | |||
| } | |||
| defer ns.Close() | |||
|
|
|||
| hostNs, err := netns.Get() | |||
| if err != nil { | |||
| return fmt.Errorf("error accessing host network namespace") | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
adding a check to verify if network namespace is not host network namespace Fixes weaveworks#3206
|
What is happening with this? |
|
I've pushed the branch to the |
bboreham
approved these changes
Jul 19, 2018
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a check to verify if network namespace is not host network namespace
Fixes #3206