This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
own action to reclaim when peer does not exist #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) but no longer exists hence lock persists foever, fix makes a peer own the reclaim when nonexistent node found Fixes #3386
murali-reddy
force-pushed
the
issue-3386
branch
from
200e74f to
7a959df
Compare
bboreham
reviewed
Oct 2, 2018
prog/kube-utils/main.go
Outdated
| } else { | ||
| // handle an edge case where peer claimed to own the action to reclaim but no longer | ||
| // exists hence lock persists foever | ||
| peerExists := false |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
prog/kube-utils/main.go
Outdated
| break | ||
| } | ||
| } | ||
| nonExistentPeer = !peerExists |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
murali-reddy
force-pushed
the
issue-3386
branch
from
ab2dca6 to
59c1abe
Compare
bboreham
approved these changes
Oct 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handles an edge case where peer claimed to own the action to reclaim but no longer exists hence lock persists forever, fix makes a peer own the reclaim when nonexistent node found
Fixes #3386