This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 672
handle gracefully add/delete of vethwedu dummy interface #3459
Open
murali-reddy
wants to merge
5
commits into
master
Choose a base branch
from
vethwedu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4b903b3
handle gracefully add/delete of vethwedu dummy interface
murali-reddy cd788fc
addressing review comment. use defer right after link creation.
murali-reddy c814651
rename the dummy interface name
murali-reddy db47f17
reuse dummy variable
murali-reddy 7f85a01
reuse dummy netlink object to delete the interface
murali-reddy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think assigning to the local variable
err
at this point has no effect.If
err
is made a named return value frominitPrep
it would work, but suppose bothLinkSetMTU
andLinkDel
fail, we'd only see one error.Maybe use a different
err
to record theLinkDel()
result and useWrap()
to add the previous error (if any).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm,
Wrap()
can only wrap one error. Maybe just add the text of this one to the previous one, if it exists.