This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Use a larger buffer than the default, so that more queries will succeed #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
360_dns_buffer
branch
from
2ff495e to
e68f4c1
Compare
|
This is intended to fix #360, right? Presumably we should open a separate issue to implement TCP fallback? |
|
Edited description and added #362. |
| @@ -77,6 +78,15 @@ func TestDNSServer(t *testing.T) { | |||
| if !(len(r.Answer) > 0) { | |||
| t.Fatal("Number of answers > 0") | |||
| } | |||
| // Now ask a query that we expect to return a lot of data. | |||
| m.SetQuestion("cisco.com.", dns.TypeANY) | |||
| m.SetEdns0(UDPBufSize, false) // Special magic to coax the other end into complying | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@bboreham what is happening with this? |
bboreham
force-pushed
the
360_dns_buffer
branch
from
e68f4c1 to
2270b42
Compare
bboreham
force-pushed
the
360_dns_buffer
branch
from
2270b42 to
458ef12
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #360. A complete fix would involve implementing TCP fallback, but raising the limit from 512 bytes to 1400 should accommodate a large fraction of real-world responses.
The 'unit' test makes the assumption that type ANY on cisco.com will give a large response. Empirically you also have to add the EDNS0 record in order to get a long response - experiment with commands like
dig ANY cisco.com. +qr +noedns