This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Avoid panic on nil map in reclaimPeer() #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error Kubernetes always returns nil on error; somehow I had the wrong idea here.
It can be set to nil after a failed update; check rather than crashing.
A previous reclaim may have left the map set to nil.
|
LGTM |
This avoids a race condition where the peer has added itself to the list and the annotation since we read storedPeerList.
|
I added another change, since I realised passing in |
|
changes LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-read peers ConfigMap from Kubernetes at start of every reclaim - a previous reclaim may have left the map set to nil.
Fixes #3613
Also make test harness and comments match Kubernetes behaviour on conflict error,
and error instead of panic if we still do somehow have a nil map