This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Add wrapper script to weave-npc #3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @ReillyProcentive for the PR. Change look good to me. |
murali-reddy
approved these changes
Aug 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3342
Closes #2628
This just adds a simple wrapper script around weave-npc that launches it with any arguments specified in the
EXTRA_ARGSenvironmental variable. This makes weave-npc consistent with weave-kube.I chose this approach as it was simpler and less likely to introduce bugs compared to adding environmental variable support to the weave-npc binary itself.
This has been tested in our own Kubernetes cluster.