Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Use buffered chan to avoid losing docker events #3705

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Conversation

bboreham
Copy link
Contributor

Docker imposes a limit that events have to be retrieved within 100ms or they are dropped on the sending side. Adding buffer space within the Weave Net process allows those events to be collected from Docker more quickly.

1024 is an arbitrary number, much higher than we expect to need.

Fixes #3432

Docker imposes a limit that events have to be retrieved within 100ms
or they are dropped on the sending side. Adding buffer space within
the Weave Net process allows those events to be collected from Docker
more quickly.

1024 is an arbitrary number, much higher than we expect to need.
@murali-reddy
Copy link
Contributor

LGTM

@bboreham bboreham merged commit 753c7cc into 2.5 Oct 3, 2019
@bboreham bboreham deleted the buffer-docker-events branch October 3, 2019 13:01
@bboreham bboreham added this to the 2.6 milestone Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants