This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Slim utility binaries by reducing dependencies #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
slim-dependencies
branch
from
77d90be
to
bbe48bb
Compare
We don't want everyone that uses the `net` package to get a transitive dependency on the Kubernetes APIs required by `npc`.
We don't want everyone that uses the `net` package to get a transitive dependency on the Kubernetes APIs, so have it define the `UID` type. Conceptually this is a simple change because `UID` is a `string`, but unfortunately it is used in a lot of places.
This means that users don't drag in a dependency on aws-sdk.
bboreham
force-pushed
the
slim-dependencies
branch
2 times, most recently
from
48b6315
to
6bc656d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got upset that
weavewaitwas 25MB when compiled with Go 1.13, and when I investigated it seemed to be because it was pulling in Kubernetes and AWS files, which it doesn't need.Unfortunately this turned into a lot of keyboarding, but I think all the changes are quite straightforward.
See individual commit messages.
The binary is 5MB after these changes, which still seems high, but much better than where I started.