-
Notifications
You must be signed in to change notification settings - Fork 670
support Iptables 1.8 with legacy and nf_tables support #3747
Conversation
Should we do anything for the non-Kubernetes case? I.e. the |
tested the auto detection logic with Kubernetes 1.17(kube-proxy and kubelet using iptables nft mode) and Debain buster (iptables with nftable as default)
We could ask users to use iptables-legacy on the host (for e.g.) for the moment so even update to the base image should work fine. Alternatively we could soft-link to appropriate binaries in the weave container during |
prog/weave-kube/launch.sh
Outdated
rm /sbin/iptables | ||
rm /sbin/iptables-save | ||
rm /sbin/iptables-restore | ||
ln /sbin/iptables-nft /sbin/iptables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Alpine appears to use symbolic links (ln -s
), I think we should follow suit, just in case it causes confusion.
# Setup iptables backend to be legacy or nftable | ||
setup_iptables_backend() { | ||
if [ -n "${IPTABLES_BACKEND}" ]; then | ||
mode=$IPTABLES_BACKEND |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add this var to docs
791dd75
to
83024b9
Compare
Updated base branch to 2.6 and addressed review comments. |
Fixes #3465
need to test with Kubernetes 1.17 which has kube-proxy in nft mode