This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Add 'finished' chan to stop callers blocking on closed connection #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you want a |
bboreham
force-pushed
the
411_closed_connections
branch
from
93d9bd4 to
78d2a3e
Compare
|
Re-pushed with |
rade
added a commit
that referenced
this pull request
Feb 24, 2015
Add 'finished' chan to stop callers blocking on closed connection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a source of deadlock in weave arising from LocalConnection's habit of exiting its queryLoop() routine while callers are trying to talk to it. After there are 16 messages in the channel, the sends block, and some of them can be from places where locks are held.
This PR introduces a second 'finished' channel, which is closed on exit from queryLoop(). All callers select on the 'finished' channel as well as the 'query' channel, and since a closed channel is always ready to read, they do not block.
This issue was found while investigating #411, but without stack traces I cannot be absolutely certain that this is the cause of that incident.