This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Remove deadlock in sending protocol messages #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rade
added a commit
that referenced
this pull request
Feb 27, 2015
Remove deadlock in sending protocol messages Closes #415.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #415, the Actor channels into LocalPeer and a Connection can get locked in a deadly embrace.
But, we don't need to use the Actor mechanism for outgoing ProtocolMsg sends; they don't need to be serialised with the state of the Connection itself, so by doing the send directly we avoid this problem.
This then opens up a related problem that the Shutdown() arising from an error when sending can get blocked on a full channel, so we move all Shutdown() operations to their own goroutines.
Closes #415. Possibly related to #411.