This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
419 broadcast frametoobigerror #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If forwarding of a broadcast frame resulted in a FrameTooBigError, we would generate an ICMP "fragmentation needed" packet that contravened RFC1122 on two counts: First, we should not produce a ICMP error message in response to a broadcast/multicast packet. Secondly, we should not produce an IP packet with a broadcast/multicast source IP address. (It also gave an ethernet frame with a broadcast source MAC, which probably contravenes some IEEE spec.) So when RelayBroadcast gets a FrameTooBigError, it should just drop the packet. Futhermore, if we fail to relay a broadcast on one connection, that's not a good reason to give up entirely - we can proceed to attempt to relay on the other next hop connections. Errors other than FrameTooBigError that propagated upwards were simply logged, so that logging is moved down into RelayBroadcast.
dpw
force-pushed
the
419_broadcast_frametoobigerror
branch
from
6f0992f to
5b66daf
Compare
|
Rebased, which apparently causes GH to orphan all the comments against the previous version of the branch. Comments were addressed. |
|
LGTM |
|
!LGTM |
or is that DNLGTM? |
rade
added a commit
that referenced
this pull request
Mar 6, 2015
Do not inject ICMP "fragmentation needed" for broadcast packets. It's a contravention of RFC1122 and also breaks weave routing due to producing packets with broadcast addresses as the source. Fixes #419.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #419.