-
Notifications
You must be signed in to change notification settings - Fork 673
Include weave dns information in weave status
#465
Conversation
Tests weren't compiling due to change of ListenHttp() signature. Fixed for now by reintroducing domain parameter in addition to server, as this allows the HTTP tests to pass in a nil server parameter. In the long term DNSServer should probably become an interface so we can mock it easily in such a scenario.
I've taken Gorilla mux out of this PR, will reintroduce it in a separate patch that covers the weave router too. |
Conflicts: nameserver/http.go
Invite @inercia for review. |
Documentation update to follow shortly... |
Everything looks good to me 👍 |
ae8e77c
to
66f4fd9
Compare
@rade re: your other comments lost due to my force push:
I'm not sure this is possible as it's pointing to something outside of the |
https://help.github.com/articles/relative-links-in-readmes/ - worth a try
I don't think I put them there ;) |
Those relative links will work if you browse to the markdown documents via the github repository browser, but they will break once |
Include weave dns information in `weave status` Closes #237.
Addresses #237 - Add weavedns status to
weave status
.Sample output:
Implementation notes:
/status
returning a human readabletext/plain
document to mirror the current router REST APIcurl -X
behaviour