This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Use docker stop instead of docker kill #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason we use 'kill' is that in the past we frequently saw 'stop' not terminating. Might have been this problem, in which case it's fixed in recent kernels. |
rade
added a commit
that referenced
this pull request
Apr 1, 2015
Use docker stop instead of docker kill
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference is that
docker stopsendsSIGTERMfirst, whereasdocker killjust sendsSIGKILL, and the latter cannot be caught by a process. Although we don't presently know of anything that needs to shut down nicely, it seems better to use the variant that permits it.