Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Ensure make stops on error from go test #557

Closed
wants to merge 1 commit into from

Conversation

bboreham
Copy link
Contributor

Changed command separator from ; to &&.

In the absence of this (or something like set -e), make will carry on and report the exit status from the next command, which is generally 0 i.e. success.

@rade
Copy link
Member

rade commented Apr 14, 2015

This does have the disadvantage of stopping on the first failing test set, doesn't it? @dpw

@bboreham
Copy link
Contributor Author

I just checked, and actually it does the opposite - if an earlier test fails but later one succeeds it will return 0 for the whole lot. Back to the drawing board.

@dpw
Copy link
Contributor

dpw commented Apr 14, 2015

This does have the disadvantage of stopping on the first failing test set, doesn't it? @dpw

Looks like it,

It should probably be restructured so that there is an tests empty target that depends on some per-dir test runner targets. It can probably be done with a static pattern.

@bboreham
Copy link
Contributor Author

We had two much simpler variants before and after 592be90

The multi-line script came in with #505, to generate a consolidated coverage report.

@bboreham
Copy link
Contributor Author

Changed to accumulate the error in a variable fail

@rade rade closed this in f9ea3f5 Apr 14, 2015
@rade
Copy link
Member

rade commented Apr 14, 2015

Fixed the cosmetic issue. rebased. merged.

@rade rade modified the milestone: 0.10.0 Apr 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants