Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Add optional hostname argument to weave expose #566

Merged
merged 1 commit into from
Apr 16, 2015

Conversation

awh
Copy link
Contributor

@awh awh commented Apr 16, 2015

Fix #375:

vagrant@ubuntu-14:~/weave$ ./weave expose 10.1.1.1/24 -h myservice.weave.local
vagrant@ubuntu-14:~/weave$ ./weave status
weave router git-59ae50eb4ef9
Encryption off
Our name is 7a:c5:c4:15:be:33(ubuntu-14)
Sniffing traffic on &{10 65535 ethwe 16:3d:0b:8a:66:e4 up|broadcast|multicast}
MACs:
7a:c5:c4:15:be:33 -> 7a:c5:c4:15:be:33(ubuntu-14) (2015-04-16 09:23:30.45427506 +0000 UTC)
6a:0a:da:89:30:de -> 7a:c5:c4:15:be:33(ubuntu-14) (2015-04-16 09:22:13.804277587 +0000 UTC)
16:3d:0b:8a:66:e4 -> 7a:c5:c4:15:be:33(ubuntu-14) (2015-04-16 09:22:03.786283726 +0000 UTC)
32:dd:63:79:54:df -> 7a:c5:c4:15:be:33(ubuntu-14) (2015-04-16 09:22:04.374157935 +0000 UTC)
Peers:
Peer 7a:c5:c4:15:be:33(ubuntu-14) (v0) (UID 5547860031843093274)
Routes:
unicast:
7a:c5:c4:15:be:33 -> 00:00:00:00:00:00
broadcast:
7a:c5:c4:15:be:33 -> []
Reconnects:


weave DNS git-59ae50eb4ef9
Local domain weave.local.
Listen address :53
mDNS interface &{14 65535 ethwe 6a:0a:da:89:30:de up|broadcast|multicast}
Fallback DNS config &{[66.28.0.45 8.8.8.8] [] 53 1 5 2}
Zone database:
weave:expose 10.1.1.1 myservice.weave.local.

There are however a number of caveats as compared to the behaviour of -h as used in conjunction with run:

  • weave hide cannot remove the DNS entries in the same way that weave detach does as there is no container in which to persist the metadata
  • We have to use the synthetic container ID of weave:expose when we interact with the DNS REST API (@inercia can you foresee any problems with this?)

@inercia
Copy link
Contributor

inercia commented Apr 16, 2015

@awh I think it should be ok to have synthetic names like that... in fact, I will introduce a remote container ID in my next PR, so weave:expose should not be problematic either...

@rade
Copy link
Member

rade commented Apr 16, 2015

We should make hide work properly for this.

@rade rade assigned awh Apr 16, 2015
@awh
Copy link
Contributor Author

awh commented Apr 16, 2015

D'oh - the REST API doesn't require the hostname so fix is trivial...

@awh awh force-pushed the name_exposed_addresses_in_weavedns branch from a1c9c34 to 4d94133 Compare April 16, 2015 14:20
@awh awh assigned rade and unassigned awh Apr 16, 2015
rade added a commit that referenced this pull request Apr 16, 2015
Add optional hostname argument to weave expose

Closes #375.
@rade rade merged commit 8f4d894 into weaveworks:master Apr 16, 2015
@rade rade modified the milestone: 0.10.0 Apr 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dns] naming 'expose'd hosts
3 participants