Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Fix multi cidr error messages #570

Merged
merged 3 commits into from
Apr 17, 2015

Conversation

awh
Copy link
Contributor

@awh awh commented Apr 17, 2015

Fixes #568:

vagrant@ubuntu-14:~/weave$ ./weave run -ti ubuntu
Invalid CIDR: -ti
CIDR must of be of form <ip_address>/<routing_prefix_length>, e.g. 10.2.1.1/24
vagrant@ubuntu-14:~/weave$ ./weave start foo bar
Invalid CIDR: foo
CIDR must of be of form <ip_address>/<routing_prefix_length>, e.g. 10.2.1.1/24
vagrant@ubuntu-14:~/weave$ ./weave attach foo bar
Invalid CIDR: foo
CIDR must of be of form <ip_address>/<routing_prefix_length>, e.g. 10.2.1.1/24
vagrant@ubuntu-14:~/weave$ ./weave detach foo bar
Invalid CIDR: foo
CIDR must of be of form <ip_address>/<routing_prefix_length>, e.g. 10.2.1.1/24
vagrant@ubuntu-14:~/weave$ ./weave expose foo
Invalid CIDR: foo
CIDR must of be of form <ip_address>/<routing_prefix_length>, e.g. 10.2.1.1/24
vagrant@ubuntu-14:~/weave$ ./weave hide foo
Invalid CIDR: foo
CIDR must of be of form <ip_address>/<routing_prefix_length>, e.g. 10.2.1.1/24
vagrant@ubuntu-14:~/weave$ ./weave hide 10.0.0.1/24 foo
Invalid CIDR: foo
CIDR must of be of form <ip_address>/<routing_prefix_length>, e.g. 10.2.1.1/24

@awh awh assigned rade Apr 17, 2015
@awh awh force-pushed the fix_multi_cidr_error_messages branch from 799e74c to 3943b02 Compare April 17, 2015 12:55
@awh
Copy link
Contributor Author

awh commented Apr 17, 2015

Updated as discussed.

rade added a commit that referenced this pull request Apr 17, 2015
@rade rade merged commit 3974b92 into weaveworks:master Apr 17, 2015
@rade rade modified the milestone: 0.10.0 Apr 18, 2015
@awh awh deleted the fix_multi_cidr_error_messages branch April 28, 2015 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weave run/attach/detach do not give correct error message if an invalid CIDR is given
2 participants