This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
simplify remote execution #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is desirable since we want to do as little as possible locally, and not duplicate any checks.
for more logical grouping
|
There is less going on here than the overall diff indicates. It might make sense to review the individual commits. The overall diff is larger than one might hope due to a) the need to move up the cidr validation functions, b) the move of the docker version validation code, and c) the removal of the condition around all the prerequisite checks, which really is just the removal of two lines and some leading whitespace but shows up as something far more complicated. |
|
before (i.e. on master) after (i.e. on this branch) |
rade
force-pushed
the
574_simplify_remote_execution
branch
from
8121358 to
a003d47
Compare
pull all the local `weave run` execution into one place, thus dispensing with the need to have lots of tests for whether we are executing in the context of "--local". Also, we only remote exec dns-args if "--with-dns" is supplied, which is more efficient in the common case (and also more obvious). NB: we need to retain the docker version check for `run` since the specific breakage it guards against does affect the code we execute locally for `run`.
it makes more sense to strip off the `--with-dns` at the call site. `weave dns-args` now does something useful, instead of having to be invoked as `weave dns-args --with-dns`.
rade
force-pushed
the
574_simplify_remote_execution
branch
from
a003d47 to
b4c0005
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do as little as possible (and more obviously so) locally.
runrundns_argsCloses #574.