Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

shrink dns tests and prevent exit on failure #595

Merged
merged 2 commits into from
Apr 23, 2015

Conversation

rade
Copy link
Member

@rade rade commented Apr 22, 2015

No description provided.

- use 'host' to lookup MX record. It's shorter
- use getent everywhere else for dns lookups, instead of dig; this
  tests more of the o/s name resolution machinery and is generally
  shorter.
- introduce assert_dns_record helper that performs forward and reverse
- lookup introduce some vars for holding constants, so we don't have
  to repeat them
since that will cause the test to exit on failure
@rade rade assigned awh Apr 22, 2015
@awh
Copy link
Contributor

awh commented Apr 23, 2015

I've confirmed that the non-zero exit status returned by the getent calls in the first commit do trigger the

---= !!!ABNORMAL TEST TERMINATION!!! =---

message.

awh added a commit that referenced this pull request Apr 23, 2015
shrink dns tests and prevent exit on failure
@awh awh merged commit dd21cfa into weaveworks:master Apr 23, 2015
@rade rade modified the milestone: 0.11.0 May 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants