This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
refactor: eliminate duplication in nameserver query handlers #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increasing their similarity in preparation of refactor
in preparation of extracting common helper function
to remove duplication between queryHandler and rdnsHandler
|
It will likely be easier to review the individual commits instead of the entire diff. |
| func (s *DNSServer) rdnsHandler(proto dnsProtocol) dns.HandlerFunc { | ||
| fallback := s.notUsHandler(proto) | ||
| func (s *DNSServer) commonQueryHandler(proto dnsProtocol, kind string, qtype uint16, | ||
| zoneLookup func(ZoneLookup, *dns.Question, *dns.Msg) (*dns.Msg, []ZoneRecord, error), fallback dns.HandlerFunc) dns.HandlerFunc { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
inercia
added a commit
that referenced
this pull request
Apr 27, 2015
refactor: eliminate duplication in nameserver query handlers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.