This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
External clock provider for the cache #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me - separate commits are a definite improvement, thankyou. There are a few things which I think could have been teased out further, I'll go through and comment on them but don't worry about updating the PR (unless you want to practice your interactive rebase commit splitting skills! :D ) - it's just for future reference... |
|
LGTM! |
awh
added a commit
that referenced
this pull request
Apr 28, 2015
External clock provider for the cache
|
Thanks! @awh |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an external clock provider in the cache, specially useful for unit testing. We do not need the "now" parameter in the cache anymore...
Added a TTL for the zone database records.
Stringer'ify some structs.
Improved Zone database mock.